Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refratoring LivePersona - remove context #1108

Merged
merged 1 commit into from Jan 29, 2022
Merged

Refratoring LivePersona - remove context #1108

merged 1 commit into from Jan 29, 2022

Conversation

joaojmendes
Copy link
Collaborator

Q A
Bug fix? [ ]
New feature? [ ]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Change LivePersona , it had the serviceScope and context properties, but the control only needed serviceScope, I removed the context.

@joelfmrodrigues joelfmrodrigues merged commit 8a05549 into pnp:dev Jan 29, 2022
@joelfmrodrigues
Copy link
Collaborator

@joaojmendes many thanks, PR merged. Please note that I edited the PR to exclude changes to test controls and also package-lock files. I also updated very slightly the change to documentation.
Thanks for the very quick update!

@AJIXuMuK AJIXuMuK mentioned this pull request Feb 12, 2022
@debarunbanerjee2018
Copy link

Suddenly it stopped working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants