Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monaco editor - New Control #1134

Merged
merged 11 commits into from
Mar 8, 2022
Merged

Monaco editor - New Control #1134

merged 11 commits into from
Mar 8, 2022

Conversation

joaojmendes
Copy link
Collaborator

Q A

| New feature? | [X]

What's in this Pull Request?

New Control Monaco Editor

@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Mar 5, 2022

@joaojmendes - could you please check the package.json?
You're importing monaco-editor but I don't see it referenced.
And as a result:
Screen Shot 2022-03-05 at 5 24 16 PM

@joaojmendes
Copy link
Collaborator Author

Hi @AJIXuMuK , I updated my branch with the latest "master", and added the missing package. I tested and for me everything is working.
Screenshot 2022-03-06 at 15 17 01
Screenshot 2022-03-06 at 15 25 01

Please tell me if everything is ok.
Thank you very much

@AJIXuMuK AJIXuMuK merged commit 0205b5b into pnp:dev Mar 8, 2022
@AJIXuMuK AJIXuMuK added this to the 3.7.0 milestone Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants