Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor documentation fix #1147

Merged
merged 2 commits into from
Mar 18, 2022
Merged

minor documentation fix #1147

merged 2 commits into from
Mar 18, 2022

Conversation

MathijsVerbeeck
Copy link

@MathijsVerbeeck MathijsVerbeeck commented Mar 11, 2022 •
edited
Loading

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues?

What's in this Pull Request?

Fixed a minor documentation error

@joelfmrodrigues
Copy link
Collaborator

Hi @Mathizor , many thanks for the PR.
I can confirm that there is an issue with the documentation, but when checking the interface I can see that the property accepts both string and JSX.Element, so I think we need to escape the | character and have both properties
image

Can you please update the PR?

@AJIXuMuK AJIXuMuK merged commit 96dae2f into pnp:dev Mar 18, 2022
@AJIXuMuK
Copy link
Collaborator

Thank you @MathijsVerbeeck for the fix!

@AJIXuMuK AJIXuMuK added this to the 3.7.0 milestone Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MathijsVerbeeck @joelfmrodrigues @AJIXuMuK