Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing TreeView nodes to expand and selection issues #1184

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Fixing TreeView nodes to expand and selection issues #1184

merged 1 commit into from
Apr 19, 2022

Conversation

Dixdjo
Copy link

@Dixdjo Dixdjo commented Apr 7, 2022 •
edited
Loading

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #1182 #1170 #1062

What's in this Pull Request?

  • nodesToExpand from TreeItem now takes nodesToExpand + defaultExpandedKeys instead of just defaultExpandendKeys
    image
  • handleTreeExpandCollapse now updating nodesToExpand content
  • pathTo function from TreeView wont add duplicates to nodesToExpand
  • When populating children on first expand wont open all closed section containing selected childrens
    image

You can ignore the other participant for this PR. JoelM365 is my second account. Joel Lopes is my main account.

I'm available if you have any questions.
Have a nice day.
Joel

@Dixdjo Dixdjo marked this pull request as draft April 8, 2022 11:30
@Dixdjo Dixdjo marked this pull request as ready for review April 8, 2022 12:28
@AJIXuMuK AJIXuMuK added this to the 3.8.0 milestone Apr 19, 2022
@AJIXuMuK AJIXuMuK merged commit 37bc0eb into pnp:dev Apr 19, 2022
@AJIXuMuK
Copy link
Collaborator

Thank you @Dixdjo for the fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dixdjo @AJIXuMuK @JoelM365