Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Theme support for AccessibleAccordion control #1200

Merged

Conversation

fabiofranzini
Copy link
Collaborator

Q A
Bug fix? [ ]
New feature? [X]
New sample? [ ]
Related issues? fixes #1195

What's in this Pull Request?

With this PR I resolved the problem described in #1195.

I made these changes:

  • added to the theme property to the control
  • changed the CSS file using CSS variables
  • changed the Accordion control to inject CSS variables for theming
  • changed the documentation
  • updated the test Web Part.

In preferred to not rewrite all the control (because it's a complex control) and maintain the original CSS file by using CSS variable to inject the correct colors.

This is the result:
AccessibleAccordionTTheme

@AJIXuMuK AJIXuMuK merged commit ea33c3e into pnp:dev May 2, 2022
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented May 2, 2022

Thank you @fabiofranzini!

@AJIXuMuK AJIXuMuK added this to the 3.8.0 milestone May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants