Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changelog script by setting CHANGELOG.JSON filename extension to lower case #1242

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

danwatford
Copy link
Contributor

Q A
Bug fix? [X]
New feature? [ ]
New sample? [ ]
Related issues?

What's in this Pull Request?

The git pre-commit hook currently fails when running on hosts with case-sensitive filesystems.
Renaming the CHANGELOG.JSON file to use a lower case .json extension resolves this issue.

@danwatford
Copy link
Contributor Author

Hi @joelfmrodrigues , this should fix the issue you are seeing with the pre-commit hook.

@joelfmrodrigues
Copy link
Collaborator

@danwatford good point, case sensitive 🙂
image
Thank you!

@joelfmrodrigues joelfmrodrigues merged commit 1084bf7 into pnp:dev Jun 22, 2022
@danwatford danwatford deleted the changelog-script-fix branch June 22, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants