Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicForm Add support for webAbsoluteUrl #1244

Merged
merged 5 commits into from
Jul 1, 2022
Merged

Conversation

6gal6ler6
Copy link
Contributor

Q A
Bug fix? [ ]
New feature? [*]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

  • Added webAbsoluteUrl to IDynamicFormProps interface
  • Edited the contructorto define the sp setup based on the existence of the prop webAbsoluteUrl
  • Created a new private prop to define the web url private webURL base on the exitence of webAbsoluteUrl prop
  • Edited 7 lines of code to include the new private webURL as parameter
    • Edited Lines
  • Added a condition to hide save and cancel button when disabled

@AJIXuMuK
Copy link
Collaborator

Thank you @6gal6ler6 for the improvements!
Could you please resolve the conflicts for the PR?

Thanks!

@6gal6ler6
Copy link
Contributor Author

6gal6ler6 commented Jun 29, 2022

I think I managed to fix the conflicts

@6gal6ler6 6gal6ler6 changed the title Add support for webAbsoluteUrl DynamicForm Add support for webAbsoluteUrl Jun 29, 2022
@6gal6ler6 6gal6ler6 changed the title DynamicForm Add support for webAbsoluteUrl DynamicForm Add support for webAbsoluteUrl Jun 29, 2022
@AJIXuMuK AJIXuMuK merged commit cb8e35b into pnp:dev Jul 1, 2022
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Jul 1, 2022

Thanks @6gal6ler6!

@AJIXuMuK AJIXuMuK added this to the 3.9.0 milestone Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants