Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed react import to fix "cannot be used as a JSX component" error #1500

Merged
merged 2 commits into from May 3, 2023

Conversation

andreasomayrat
Copy link
Contributor

Q A
Bug fix? [ x ]
New feature? [ ]
New sample? [ ]
Related issues?

What's in this Pull Request?

Changed React import in FieldPicker to "import * as React from 'react' " to prevent " 'FieldPicker' cannot be used as a JSX component"-error that appears in some projects

@fabiofranzini
Copy link
Collaborator

Hi @andreasomayrat thanks for this fix!
I encountered a problem in the Web Part to test the control... You used a List Id that is obviously not present on my Tenant (same for other users). This causes the Web Part to fail causing it not to render.
Can you fix this?
Could you for example use the 'ListPicker' control for the demo and pass the List Id to the 'FieldPicker' control?
Thank you :)

@ghost ghost removed the Needs: Author Feedback label Apr 11, 2023
@andreasomayrat
Copy link
Contributor Author

Hello @fabiofranzini

I have now updated the code to use the selected list from the ListPicker component

@joelfmrodrigues joelfmrodrigues merged commit 10c6ac6 into pnp:dev May 3, 2023
1 check passed
@joelfmrodrigues
Copy link
Collaborator

@andreasomayrat sorry for the delay, this is now merged. Many thanks for your contribution

@joelfmrodrigues joelfmrodrigues added this to the 3.15.0 milestone May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants