Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds panelProps property to FieldCollectionData #1525

Merged
merged 1 commit into from Apr 30, 2023

Conversation

c-eiser13
Copy link
Contributor

Adds panelProps property to FieldCollectionData to have better control of the underlying panel. Also updates docs.

Q A
Bug fix? [ ]
New feature? [ x]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

This PR adds a panelProps property to the FieldCollectionData to allow passing other panel props to the control. Main use case is overriding the fixed PanelSize.Large prop, and using a wider/more narrow, or fixed near panel. Same change was implemented in the Property Controls project.

…er control of the underlying panel. Also updates docs.
@joaojmendes joaojmendes self-assigned this Apr 30, 2023
@joaojmendes joaojmendes self-requested a review April 30, 2023 18:00
@joaojmendes joaojmendes added the type:enhancement New feature or enhancement of existing capability label Apr 30, 2023
@joaojmendes joaojmendes added this to the 3.14.0 milestone Apr 30, 2023
@joaojmendes
Copy link
Collaborator

thank you @c-eiser13 , for the PR.

@joaojmendes joaojmendes merged commit b7c9f50 into pnp:dev Apr 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants