Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ControlsTestWebPart #1547

Merged

Conversation

GuidoZam
Copy link
Contributor

@GuidoZam GuidoZam commented Jun 3, 2023

Q A
Bug fix? [ ]
New feature? [ ]
New sample? [ x ]

What's in this Pull Request?

Updated the ControlsTestWebPart to show the controls filtered by control type to avoid display everything all at once.

@joelfmrodrigues
Copy link
Collaborator

@GuidoZam Many thanks for this!
There is a PR that was submitted earlier to add a new control that I aim to review before this one as it adds a new control to the page. We will try to get to this one soon

@joelfmrodrigues
Copy link
Collaborator

@GuidoZam I really like it! So much better than the pile of controls we have at the moment 🤩

image

image

@joelfmrodrigues
Copy link
Collaborator

joelfmrodrigues commented Jun 23, 2023

Just waiting for #1526 so we can add the new control here as well and merge after that

@GuidoZam
Copy link
Contributor Author

Thanks @joelfmrodrigues, I'm happy that you like it 😄

@joelfmrodrigues joelfmrodrigues self-requested a review July 6, 2023 11:30
@joelfmrodrigues joelfmrodrigues merged commit 63d4875 into pnp:dev Jul 6, 2023
1 check passed
@joelfmrodrigues joelfmrodrigues added this to the 3.15.0 milestone Jul 6, 2023
@joelfmrodrigues
Copy link
Collaborator

@GuidoZam many thanks! This is now merged

@GuidoZam GuidoZam deleted the guidozam-reordered-controltestwebpart branch July 6, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants