Fix ModernTaxonomyPicker used language by checking for supported term… #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… store languages
What's in this Pull Request?
Changing how the language used by the ModernTaxonomyPicker is set by checking the currentUICultureName against the termStoreInfo.languageTags array and use currentTermStoreInfo.defaultLanguageTag if the current UI language is not supported (= not inside the termStoreInfo.languageTags array) by the term store.
I also noticed that the
currentTermStoreInfostate was used directly after being set (it would be undefined because state update is asynchronous) which must have caused another bug if the currentUICultureName wasn't available. So I used the fetchedtermStoreInfoinstead of the state.Thanks!