Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicForm Number min max #1585

Merged
merged 2 commits into from Jul 14, 2023
Merged

Conversation

GuidoZam
Copy link
Contributor

Q A
Bug fix? [ ]
New feature? [ ]
New sample? [ ]
Enhancement [ x]

What's in this Pull Request?

Enhanced the check for minimum and maximum number values in DynamicForm control. The control now supports also fields that requires only the minimum or maximum limitation and not always both of them.

I translated all the localization strings with Google translate, hopefully those are correct 馃

@GuidoZam
Copy link
Contributor Author

This is what it looks like with the PR:

image

@joaojmendes joaojmendes self-requested a review July 13, 2023 21:49
@joaojmendes joaojmendes self-assigned this Jul 13, 2023
@joaojmendes joaojmendes added the status:fixed-next-drop Issue will be fixed in upcoming release. label Jul 13, 2023
@joaojmendes joaojmendes added this to the 3.15.0 milestone Jul 13, 2023
@joaojmendes
Copy link
Collaborator

@GuidoZam Thank you very much for the PR

@joaojmendes joaojmendes merged commit 8998b5d into pnp:dev Jul 14, 2023
1 check passed
@GuidoZam GuidoZam deleted the patch-number-min-max branch July 14, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants