Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FieldCollectionData enhancements #1588

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Conversation

RicoNL
Copy link
Contributor

@RicoNL RicoNL commented Jul 13, 2023

Q A
Bug fix? [ ]
New feature? [X]
New sample? [ ]
Related issues?

What's in this Pull Request?

  • optionally open fieldCollectionData-control directly on the page instead of panel
  • added combobox and peoplepicker to CustomCollectionFieldType

Copy link
Collaborator

@joelfmrodrigues joelfmrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @RicoNL , please review the requested change

@joelfmrodrigues joelfmrodrigues self-assigned this Sep 11, 2023
@joelfmrodrigues
Copy link
Collaborator

@RicoNL could you please also update the Test component to use the new options?

@joelfmrodrigues joelfmrodrigues merged commit 0c339df into pnp:dev Sep 11, 2023
1 check passed
@joelfmrodrigues
Copy link
Collaborator

@RicoNL many thanks!
I merged it even though I asked for new properties to be added to the test component....feel free to submit a new PR for this if you want, but fine if not as not a major problem

@joelfmrodrigues joelfmrodrigues added this to the 3.16.0 milestone Sep 11, 2023
@RicoNL RicoNL deleted the FieldCollectionData branch September 11, 2023 20:28
@RicoNL
Copy link
Contributor Author

RicoNL commented Sep 12, 2023

hi @joelfmrodrigues , I was working on the test component but I'm having difficulties to get the ControlsTest-webpart to work on my devtenant. This is the error message I'm having. Any ideas?

image

The error message in the console points to code below:
image

@joelfmrodrigues
Copy link
Collaborator

hi @joelfmrodrigues , I was working on the test component but I'm having difficulties to get the ControlsTest-webpart to work on my devtenant. This is the error message I'm having. Any ideas?

image The error message in the console points to code below: ![image](https://user-images.githubusercontent.com/35333175/267260052-309e6dad-433d-4917-af3e-631dc390285e.png)

@RicoNL Sorry I merged the PR, wasn't sure if you were still working on updates, but feel free to submit a separate PR.

Regarding the error, I noticed that myself yesterday and I think it only happens when using fast-serve. Can you confirm that it works when using gulp serve as a workaround? When I switched to gulp serve the error went away for me.
Please let me know if you will create a new issue for this one, otherwise, I will create one so other people can find it and discuss

@RicoNL
Copy link
Contributor Author

RicoNL commented Sep 12, 2023

Thanks @joelfmrodrigues , that seems to work. I will create a new PR for the test component.

@RicoNL
Copy link
Contributor Author

RicoNL commented Sep 12, 2023

@joelfmrodrigues PR for controlstest has been submitted: #1642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants