Fixing issue 1612 & 1603 - PeoplePicker won't accept Multiple Users with the same name

[NishkalankBezawada]

Q	A
Bug fix?	[x]
New feature?	[ ]
New sample?	[ ]
Related issues?	fixes #1612 & #1603

What's in this Pull Request?

Fixing Issue #1612
Fixing Issue #1603

Problem Statement

People picker wont accept users with same First Name & Last Name but with different LoginName/Emails.

Steps to reproduce

Added few Users in EntraID as below

First Name	Last Name	Email
John	Smith	john.smith.01@pm3q.onmicrosoft.com
John	Smith	john.smith.02@pm3q.onmicrosoft.com
John	Smith	john.smith.03@pm3q.onmicrosoft.com

With this, If we are selecting John Smith with email john.smith.01@pm3q.onmicrosoft.com at first, we are not able to add other Users with same names but with different emails as above.

Solution

In PeoplePickerComponent, onSearchFieldChanged after results are fetched, the results are sent to 'removeDuplicates' to the method, listContainsPersona

This method was just filtering with the names as below,

  private listContainsPersona = (persona: IPersonaProps, personas: IPersonaProps[]): boolean => {
    if (!personas || !personas.length || personas.length === 0) {
      return false;
    }
    return personas.filter(item => item.text === persona.text).length > 0;
  }

And with this reason, the next user is not getting accepted, as the below code returns true always
return personas.filter(item => item.text === persona.text).length > 0;

By making a change as below to also compare with secondaryText will get the users with same names and with different emails

  private listContainsPersona = (persona: IPersonaProps, personas: IPersonaProps[]): boolean => {
    if (!personas || !personas.length || personas.length === 0) {
      return false;
    }
    return personas.some(item => item.text === persona.text && item.secondaryText === persona.secondaryText);
  }

With this change, PeoplePicker will accept users with same First Name & Last Name but with different LoginName/Emails (Gif below)

Thanks,
Nishkalank Bezawada

[sionjlewis]

Thank you @NishkalankBezawada.
Do you have any idea when your fix may be released for general use?

[NishkalankBezawada]

Thank you @NishkalankBezawada.

Do you have any idea when your fix may be released for general use?

Hey @sionjlewis, The maintainers has to merge my PR into DEV so that you could use the nightly build. I'm not sure about the production release though. I'll keep you posted on this

[nateforsyth]

Hey team, been a month since the last update - any word on when this will hit general availability please? We have immediate need for this fix.

[NishkalankBezawada]

Hey team, been a month since the last update - any word on when this will hit general availability please? We have immediate need for this fix.

Hi @joelfmrodrigues, Do you have any update on this.

Thanks,
Nishkalank

[joaojmendes]

Hi, @NishkalankBezawada. Thank you for your PR.