Use stringMatchOption instead of deprecated stringMatchId #1688 #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Any news on this bug ? |
|
@lafe many thanks and apologies for the delay in reviewing this. This is now merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
As discussed in #1688 it appears that the
stringMatchIdquery parameter is not supported by the searchTerm-API anymore. The fix proposed in that issue (using thestringMatchOptionquery parameter with valueStartsWith) worked.With VS Code I could not find any usages of the
searchTermfunction that uses thestringMatchId, so there are (hopefully) no side effects in the package itself. For consuming libraries, this might be a breaking change.