Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1719 @iconify/react error #1725

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

GuidoZam
Copy link
Contributor

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #1719

What's in this Pull Request?

Added iconify/react package as a dependency and not as a devDependency to avoid errors while running gulp bundle.

@joelfmrodrigues joelfmrodrigues merged commit 1c50fa8 into pnp:dev Dec 21, 2023
1 check passed
@joelfmrodrigues
Copy link
Collaborator

Many thanks @GuidoZam !

@GuidoZam GuidoZam deleted the fix-iconify-react-dependency branch December 21, 2023 16:31
@joelfmrodrigues joelfmrodrigues added this to the 3.17.0 milestone Dec 21, 2023
michaelmaillot added a commit that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants