Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileTypeIcon enhancements #1789

Merged
merged 10 commits into from
May 6, 2024
Merged

Conversation

GuidoZam
Copy link
Contributor

Q A
Bug fix? [ ]
New feature? [x]
New sample? [ ]
Related issues? #270

What's in this Pull Request?

Added some events to the FileTypeIcon control.

The new events are the following:

  • onClick
  • onDoubleClick
  • onMouseEnter
  • onMouseLeave
  • onMouseOver
  • onMouseUp

Copy link
Collaborator

@michaelmaillot michaelmaillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @GuidoZam,

Thanks for submitting this PR!

I have added a few changes to make.

src/controls/fileTypeIcon/IFileTypeIcon.ts Outdated Show resolved Hide resolved
docs/documentation/docs/controls/FileTypeIcon.md Outdated Show resolved Hide resolved
docs/documentation/docs/controls/FileTypeIcon.md Outdated Show resolved Hide resolved
docs/documentation/docs/controls/FileTypeIcon.md Outdated Show resolved Hide resolved
docs/documentation/docs/controls/FileTypeIcon.md Outdated Show resolved Hide resolved
docs/documentation/docs/controls/FileTypeIcon.md Outdated Show resolved Hide resolved
docs/documentation/docs/controls/FileTypeIcon.md Outdated Show resolved Hide resolved
GuidoZam and others added 7 commits May 1, 2024 10:04
Co-authored-by: Michaël Maillot <battosaimykle@gmail.com>
Co-authored-by: Michaël Maillot <battosaimykle@gmail.com>
Co-authored-by: Michaël Maillot <battosaimykle@gmail.com>
Co-authored-by: Michaël Maillot <battosaimykle@gmail.com>
Co-authored-by: Michaël Maillot <battosaimykle@gmail.com>
Co-authored-by: Michaël Maillot <battosaimykle@gmail.com>
@GuidoZam
Copy link
Contributor Author

GuidoZam commented May 1, 2024

Hi @michaelmaillot, thanks for the reviews. I've made the changes you asked for 👍

@michaelmaillot michaelmaillot merged commit 34f318a into pnp:dev May 6, 2024
1 check passed
@michaelmaillot
Copy link
Collaborator

Merged manually, thank you!

@michaelmaillot michaelmaillot added this to the 3.18.0 milestone May 6, 2024
@GuidoZam GuidoZam deleted the file-type-icon-enhancement branch May 7, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants