Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1101: Fix issue with adding link by typing in FilePicker "From a link" tab #1814

Merged

Conversation

Ateina
Copy link
Contributor

@Ateina Ateina commented May 4, 2024

…k" tab

Q A
Bug fix? [x ]
New feature? [ ]
New sample? [ ]
Related issues? fixes #1101

What's in this Pull Request?

Fixed issue with typing url in FilePicker control "From a link" tab.
Added error message if value is an invalid url.
Removed '"defaultValue" in TextFiend, because it doesn't affect controlled components.

@joaojmendes joaojmendes self-requested a review May 19, 2024 19:58
@joaojmendes joaojmendes self-assigned this May 19, 2024
@joaojmendes joaojmendes added the status:fixed-next-drop Issue will be fixed in upcoming release. label May 19, 2024
@joaojmendes
Copy link
Collaborator

Hi, @Ateina thank you for the fix

@joaojmendes joaojmendes merged commit e52931f into pnp:dev May 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants