Extended TaxonomyPicker with the ability to hide deprecated terms "Available for tagging" = false #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… those that are not available for tagging (Issue: 421)
3 tasks
Codecov Report
@@ Coverage Diff @@
## dev #437 +/- ##
=======================================
Coverage 73.31% 73.31%
=======================================
Files 18 18
Lines 802 802
Branches 154 154
=======================================
Hits 588 588
Misses 164 164
Partials 50 50Continue to review full report at Codecov.
|
|
Thanks for that enhancement @JonasBjerke89! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Two new properties on the ITaxonomyPicker interface that gives the consumer the ability to hide deprecated terms (instead of deactivation only) as well as "Available for tagging" = false. The service provider is extended with the two props and the terms are filtered out if used.