Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to the TreeView component to expand the nodes to see defaultSelectedKeys. #566

Merged
merged 3 commits into from
May 20, 2020

Conversation

siddharth-vaghasia
Copy link
Contributor

Q A
New feature? [ X]

| Related issues? | fixes #559

What's in this Pull Request?

Added the ability to the TreeView component to expand the nodes to see defaultSelectedKeys.
For example, add expandToSelected: boolean property to the component.

Note - This PR also includes changes for issue #560 and #561 which @nanddeepn have fixed and submitted separate PR for the same(yet not merged or approved). Not sure whether I did the right thing to include these changes in this PR but to test scenarios for my changes I need these changes here also. If not, please advise.

@AJIXuMuK AJIXuMuK merged commit 85ebd9b into pnp:dev May 20, 2020
@AJIXuMuK
Copy link
Collaborator

Hi @siddharth-vaghasia!
Thank you for the changes!
I did small updates and merged both your and @nanddeepn PRs.

@siddharth-vaghasia
Copy link
Contributor Author

thanks @AJIXuMuK .... on another note, do you think this control will be useful in Property pane repo? We were thinking if there are valid use case, we can work on it...just wanted to know your view.

@AJIXuMuK
Copy link
Collaborator

@siddharth-vaghasia - I think there might be scenarios where tree view could be used in the property pane... something like displaying documents with folder hierarchy, custom hierarchical filter, or displaying Teams and underlying Channels.
But you need to keep in mind that all of those scenarios have different data under each tree item.

We can also create a “question” in the repo to see if people are really interested in such control as I don’t want you to waste your time :)

@siddharth-vaghasia
Copy link
Contributor Author

@AJIXuMuK ...thanks..make sense.. will create a question in property pane repo to see if people are interested..!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants