Fix #799 React error in FileBrowser paging #871
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
In the file picker control, the site file picker tab uses a
<DetailList>
for file selection. If a list of files is too long and requires pagination, it calls thisonRenderMissingItem
callback. This function is asyncronous and returns a promise, but this causes a React render error becauseonRenderMissingItem
is expecting to render something.Instead, we call the asyncronous function and return null.