New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PropertyFieldChoiceGroupWithCallout deletes properties #592
Comments
Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible. |
Also happens in the PropertyControlsTestWebPart from this repository. |
One of the reasons for the bug is this change:
|
Bugfix for issue pnp#592 Switching from office-ui-fabric-react to @fluentui/react caused incompatibilities. Choice options no longer use "checked" but "defaultSelectedKey" and onChange has two parameters instead of one.
Does an error of this severity warrant a 3.15.1 release since it renders the PropertyFieldChoiceGroupWithCallout control unusable and may destroy existing web part configurations? |
@IRRDC many thanks for all the info, we are discussing it and will try to resolve it as soon as we have the chance. In the meantime, I suggest you keep using the previous version if possible. |
Noticed the same issue today, rolling back in version fixed it for now |
Thanks for reporting the issue. |
Category
Version
Please specify what version of the library you are using: [3.15.0]
Expected / Desired Behavior / Question
In the newest version the property assigned to the PropertyFieldChoiceGroupWithCallout gets deleted when a selection gets checked.
Observed Behavior
The current value does not get selected on load (anymore). It does show up when looking at it using the PropertyPanePropertyEditor.
As soon as one of the options gets checked the whole property vanishes from the PropertyPanePropertyEditor.
Steps to Reproduce
I created a fresh SPFX webpart using yo and just added the sample codes from
https://pnp.github.io/sp-dev-fx-property-controls/controls/PropertyPanePropertyEditor/
and
https://pnp.github.io/sp-dev-fx-property-controls/controls/PropertyFieldChoiceGroupWithCallout/
I also added "choiceGroupWithCalloutValue": "Android" to the manifest.json to create a default value.
Sample code:
No choice selected on load:
Property exists before making a choice:
Property is gone after making a choice:
The text was updated successfully, but these errors were encountered: