Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer: Edit My Links not working in Internet Explorer #102

Closed
2 of 3 tasks
BradNailer opened this issue Jul 23, 2018 · 9 comments
Closed
2 of 3 tasks

Footer: Edit My Links not working in Internet Explorer #102

BradNailer opened this issue Jul 23, 2018 · 9 comments
Labels
status:answered status:fixed Issue fixed in current or prior release.

Comments

@BradNailer
Copy link

Category

  • Question
  • Bug
  • Enhancement

Expected or Desired Behavior

The Edit my links feature to open when clicked while using Internet Explorer 11. Is Internet Explorer supported with the SP Starter Kit?

Observed Behavior

When the Edit link is clicked a small white rectangle is shown, the screen goes grey for a second, and the Edit my Links window does not appear.

Also, there is a graphical fault in the the footer area that only appears with using IE. Shown below:
spstarterkit_footer_bug

Steps to Reproduce

Try to click Edit in the footer when using Internet Explorer.

Thanks for you time.

@PaulMac66
Copy link

Hi Brad.

Did you ever resolve this issue? I am having the same trouble.

@BradNailer
Copy link
Author

BradNailer commented Jul 31, 2018 via email

@groveale
Copy link

I've got a fix for the graphical issue. If you update the .toggleButton css class in PortalFooter.module.scss

Change the background-color: inherit to background-color: transparent

Still working on edit button click.

Thanks

@mschaefer85
Copy link

Experiencing the same issue, unfortunately. The dialog opens, but closed immediately.

@nhadro
Copy link

nhadro commented Nov 2, 2018

Has anyone been able to resolve this issue?

@trevorhuinker
Copy link

Has anyone been able to resolve this issue?

Same here... does anyone have an update? @VesaJuvonen

@Laskewitz
Copy link
Member

Not working for me either. Would be great to have a solution for this.

@simonagren
Copy link
Member

simonagren commented Jan 4, 2019

These are the steps I had to make with the newest version of the starterkit.

What was breaking when pressing "Edit" was the usage of new Event, which doesn't work in IE.
So I changed that code.

  1. Go to this solution\src\common\myLinks\MyLinksDialog.tsx
    And on line 108 change:
window.dispatchEvent(new Event('resize'));

To:

let resizeEvent = window.document.createEvent('UIEvents'); 
resizeEvent.initUIEvent('resize', true, false, window, 0); 
window.dispatchEvent(resizeEvent); 
  1. Save and then run in Node:
    gulp bundle --ship && gulp package-solution --ship

  2. Then go to you app catalog and manually upload and deploy the new package located:
    sp-starter-kit\solution\sharepoint\solution

@simonagren
Copy link
Member

@VesaJuvonen How do you feel about supporting IE11?
Is this something I should further investigare regarding the footer and make a PR?

@bcameron1231 bcameron1231 added status:answered status:fixed Issue fixed in current or prior release. labels Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:answered status:fixed Issue fixed in current or prior release.
Projects
None yet
Development

No branches or pull requests

9 participants