fix: issue with arborist reported at npm#5007

used fix suggested in npm#5007 (comment)
pnpm · Nov 1, 2023 · 0af133e · 0af133e
1 parent e0fc634
commit 0af133e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/workspaces/arborist/lib/calc-dep-flags.js b/workspaces/arborist/lib/calc-dep-flags.js
@@ -30,7 +30,7 @@ const calcDepFlagsStep = (node) => {
   resetParents(node, 'optional')
 
   // for links, map their hierarchy appropriately
-  if (node.isLink) {
+  if (node.isLink && node.target) {
     node.target.dev = node.dev
     node.target.optional = node.optional
     node.target.devOptional = node.devOptional
@@ -97,17 +97,19 @@ const unsetFlag = (node, flag) => {
       tree: node,
       visit: node => {
         node.extraneous = node[flag] = false
-        if (node.isLink) {
+        if (node.isLink && node.target) {
           node.target.extraneous = node.target[flag] = false
         }
       },
       getChildren: node => {
         const children = []
-        for (const edge of node.target.edgesOut.values()) {
-          if (edge.to && edge.to[flag] &&
-            (flag !== 'peer' && edge.type === 'peer' || edge.type === 'prod')
-          ) {
-            children.push(edge.to)
+        if (node.target) {
+          for (const edge of node.target.edgesOut.values()) {
+            if (edge.to && edge.to[flag] &&
+              (flag !== 'peer' && edge.type === 'peer' || edge.type === 'prod')
+            ) {
+              children.push(edge.to)
+            }
           }
         }
         return children

diff --git a/workspaces/arborist/package.json b/workspaces/arborist/package.json
@@ -1,5 +1,5 @@
 {
-  "name": "@npmcli/arborist",
+  "name": "@pnpm/arborist__fork",
   "version": "7.2.1",
   "description": "Manage node_modules trees",
   "dependencies": {