Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: throw error when signal kill child process #39

Merged
merged 2 commits into from Nov 30, 2022
Merged

feat: throw error when signal kill child process #39

merged 2 commits into from Nov 30, 2022

Conversation

await-ovo
Copy link
Member

fix: pnpm/pnpm#5525

Reject error when signal kill child process such as out of memory.

npm do this at https://github.com/npm/promise-spawn/blob/main/lib/index.js#L52

@zkochan zkochan merged commit baa049a into pnpm:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkochan zkochan zkochan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@await-ovo @zkochan