Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need this mutation to ensure that both Unix and Windows paths resolves the same #60

Closed
mertcanaltin opened this issue Aug 7, 2023 · 1 comment

Comments

@mertcanaltin
Copy link
Contributor

Description:
The current implementation of the get_all_folders function potentially leads to inconsistent behavior due to differing path separators on different operating systems. To ensure consistent results and portability, it's important to handle path separators in a platform-independent manner.

Proposed Solution:
Refactor the code to utilize Rust's built-in path handling capabilities using the std::path::Path and std::path::PathBuf types. This will allow the function to automatically manage path separators according to the operating system, resulting in more predictable and reliable behavior.

I opened a pull request #59

@anonrig
Copy link
Member

anonrig commented Aug 7, 2023

This edge case is already handled properly.

@anonrig anonrig closed this as not planned Won't fix, can't repro, duplicate, stale Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants