fix: subdeps of not installable packages are ignored

pnpm · Mar 31, 2017 · 40b436c · 40b436c
1 parent d88cb27
commit 40b436c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/api/install.ts b/src/api/install.ts
@@ -83,10 +83,13 @@ export async function installPkgs (fuzzyDeps: string[] | Dependencies, maybeOpts
   }
   const ctx = await getContext(opts)
   const installCtx = await createInstallCmd(opts, ctx.shrinkwrap)
+  const optionalDependencies = opts.saveOptional
+    ? packagesToInstall.map(spec => spec.name)
+    : []
 
   return lock(
     ctx.storePath,
-    () => installInContext('named', packagesToInstall, [], ctx, installCtx, opts),
+    () => installInContext('named', packagesToInstall, optionalDependencies, ctx, installCtx, opts),
     {stale: opts.lockStaleDuration}
   )
 }

diff --git a/test/install.ts b/test/install.ts
@@ -113,6 +113,12 @@ test('scoped modules from a directory', async function (t) {
   t.equal(localPkg(), '@scope/local-scoped-pkg', 'localScopedPkg() is available')
 })
 
+test('successfully install optional dependency with subdependencies', async function (t) {
+  const project = prepare(t)
+
+  await installPkgs(['fsevents@1.0.14'], testDefaults({saveOptional: true}))
+})
+
 test('skip failing optional dependencies', async function (t) {
   const project = prepare(t)
   await installPkgs(['pkg-with-failing-optional-dependency@1.0.1'], testDefaults())