Skip to content

Commit

Permalink
test: remove redundant test
Browse files Browse the repository at this point in the history
  • Loading branch information
zkochan committed Mar 31, 2022
1 parent 3fa768c commit d74826c
Showing 1 changed file with 0 additions and 86 deletions.
86 changes: 0 additions & 86 deletions packages/core/test/install/peerDependencies.ts
Original file line number Diff line number Diff line change
Expand Up @@ -224,92 +224,6 @@ test('strict-peer-dependencies: error is thrown when cannot resolve peer depende
})
})

test('peer dependency is resolved from the dependencies of the workspace root project', async () => {
const projects = preparePackages([
{
location: '.',
package: { name: 'root' },
},
{
location: 'pkg',
package: {},
},
])
const reporter = jest.fn()
await mutateModules([
{
buildIndex: 0,
manifest: {
name: 'root',
version: '1.0.0',

dependencies: {
ajv: '4.10.0',
},
},
mutation: 'install',
rootDir: process.cwd(),
},
{
buildIndex: 0,
manifest: {
name: 'pkg',
version: '1.0.0',

dependencies: {
'ajv-keywords': '1.5.0',
},
},
mutation: 'install',
rootDir: path.resolve('pkg'),
},
], await testDefaults({ reporter }))

expect(reporter).not.toHaveBeenCalledWith(expect.objectContaining({
name: 'pnpm:peer-dependency-issues',
}))

{
const lockfile = await projects.root.readLockfile()
expect(lockfile.importers.pkg?.dependencies?.['ajv-keywords']).toBe('1.5.0_ajv@4.10.0')
}

await mutateModules([
{
buildIndex: 0,
manifest: {
name: 'root',
version: '1.0.0',

dependencies: {
ajv: '4.10.0',
},
},
mutation: 'install',
rootDir: process.cwd(),
},
{
buildIndex: 0,
manifest: {
name: 'pkg',
version: '1.0.0',

dependencies: {
'ajv-keywords': '1.5.0',
'is-positive': '1.0.0',
},
},
mutation: 'install',
rootDir: path.resolve('pkg'),
},
], await testDefaults({ reporter }))

{
const lockfile = await projects.root.readLockfile()
expect(lockfile.importers.pkg?.dependencies?.['ajv-keywords']).toBe('1.5.0_ajv@4.10.0')
}
})

test('warning is reported when cannot resolve peer dependency for non-top-level dependency', async () => {
prepareEmpty()
await addDistTag({ package: 'abc-parent-with-ab', version: '1.0.0', distTag: 'latest' })
Expand Down

0 comments on commit d74826c

Please sign in to comment.