We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To reduce the size of shrinkwrap.yaml we don't save the tarball URLs of packages from registry.npmjs.org. We can create their tarballs URLs if we know their name and version (see related code in supi: https://github.com/pnpm/supi/blob/9eb87ce9f296097f1368f150725533b3933a1d60/src/resolveDependencies.ts#L227).
shrinkwrap.yaml
registry.npmjs.org
However, some packages have weird tarball URLs. For instance, the tarball URL of esprima-fb@3001.1.0-dev-harmony-fb is https://registry.npmjs.org/esprima-fb/-/esprima-fb-3001.0001.0000-dev-harmony-fb.tgz, so we have to save its tarball URL in shrinkwrap.yaml
esprima-fb@3001.1.0-dev-harmony-fb
Currently it would be saved to shrinkwrap.yaml like this:
/esprima-fb/3001.1.0-dev-harmony-fb: dev: true engines: node: '>=0.4.0' resolution: integrity: sha1-t303q8046gt3Qmu4vCkizmtCZBE=
It should be saved like this:
/esprima-fb/3001.1.0-dev-harmony-fb: dev: true engines: node: '>=0.4.0' resolution: integrity: sha1-t303q8046gt3Qmu4vCkizmtCZBE= tarball: https://registry.npmjs.org/esprima-fb/-/esprima-fb-3001.0001.0000-dev-harmony-fb.tgz
The text was updated successfully, but these errors were encountered:
This issue is also worse if you happen to have a pnpm server running:
pnpm server
pnpm server start on an empty store
pnpm server start
with a shrinkwrap.yaml present, run pnpm install: it will fail
pnpm install
now removing shrinkwrap.yaml does not solve the issue anymore.
Sorry, something went wrong.
fix(shrinkwrap): save non-standard tarball URLs
3d3890c
ref pnpm/pnpm#1072
82a4489
🚢 1.35.9
resolved
hash
zkochan
No branches or pull requests
To reduce the size of
shrinkwrap.yaml
we don't save the tarball URLs of packages fromregistry.npmjs.org
. We can create their tarballs URLs if we know their name and version (see related code in supi: https://github.com/pnpm/supi/blob/9eb87ce9f296097f1368f150725533b3933a1d60/src/resolveDependencies.ts#L227).However, some packages have weird tarball URLs. For instance, the tarball URL of
esprima-fb@3001.1.0-dev-harmony-fb
is https://registry.npmjs.org/esprima-fb/-/esprima-fb-3001.0001.0000-dev-harmony-fb.tgz, so we have to save its tarball URL in shrinkwrap.yamlCurrently it would be saved to
shrinkwrap.yaml
like this:It should be saved like this:
The text was updated successfully, but these errors were encountered: