-
-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installing from GitHub pull request not working #2045
Labels
Projects
Comments
I'm also running into this issue. |
Too bad. Though install from commit hash is working. |
Same issue here. Does anyone have a fix? |
Has this ever been fixed? |
I still ran into this issue today, installed the dependency via |
zkochan
pushed a commit
that referenced
this issue
Jun 29, 2022
Previously, if you wanted to check out a git PR branch, you needed to specify the url as: `github:pnpm/pnpm#refs/pull/123/merge`. Now this will resolve without the leading "refs": `github:pnpm/pnpm#pull/123/merge` close #2045
zkochan
pushed a commit
that referenced
this issue
Jun 30, 2022
Previously, if you wanted to check out a git PR branch, you needed to specify the url as: `github:pnpm/pnpm#refs/pull/123/merge`. Now this will resolve without the leading "refs": `github:pnpm/pnpm#pull/123/merge` close #2045
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have the feeling there's something I'm missing but I wasn't able to find any issues mentioning this specific use-case so here we go…
pnpm version:
pnpm v3.8.1
Code to reproduce the issue:
Try to add a dependency given a PR in a public GitHub repo:
Expected behavior:
pnpm should be able to install a dependency from a given PR, matching the way both npm and yarn work. It would also be great if pnpm could accept both npm and yarn's syntax for this (they're different).
Actual behavior:
Additional information:
node -v
prints: v12.11.0The text was updated successfully, but these errors were encountered: