Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flags passed to add command ignored when used in conjunction with --filter #2294

Closed
amctavish opened this issue Jan 28, 2020 · 1 comment · Fixed by #2312
Closed

Flags passed to add command ignored when used in conjunction with --filter #2294

amctavish opened this issue Jan 28, 2020 · 1 comment · Fixed by #2312
Assignees
@zkochan
Labels
area: monorepo Everything related to the pnpm workspace feature type: bug
Milestone
v4.9

Comments

@amctavish
Copy link

pnpm version: 4.8.0

Code to reproduce the issue:

pnpm add --save-dev @types/express --filter <package_name>

Expected behavior:

I would expect the @types/express to be added to the devDependencies of the package(s) specified in the filter.

Actual behavior:

The --save-dev or -D flags appear to be being ignore as@types/express is being added to dependencies instead of devDependences.

I have also tried this with the --save-peer flag which is also being ignored. Could be as simple as all flags intended for the add command are being ignored.

Additional information:

  • node -v prints: v12:14.1
  • Windows, OS X, or Linux?: Linux (node:erbium docker container)
@zkochan zkochan added this to the v4.9 milestone Jan 28, 2020
@zkochan zkochan added the area: monorepo Everything related to the pnpm workspace feature label Jan 28, 2020
@zkochan zkochan self-assigned this Feb 1, 2020
zkochan added a commit that referenced this issue Feb 1, 2020
@zkochan
fix: add --save-dev -r
dbcbeb8 
Recursively adding dependencies using --save-dev,
--save-optional, or --save-prod should work on
workspaces that don't use a central, shared
lockfile.

close #2294
@zkochan zkochan mentioned this issue Feb 1, 2020
Merged
1 task
zkochan added a commit that referenced this issue Feb 1, 2020
@zkochan
fix: add --save-dev|--save-peer -r
50449cf 
Recursively adding dependencies using --save-dev,
--save-optional, --save-peer, or --save-prod should work on
workspaces that don't use a central, shared
lockfile.

BREAKING CHANGE:

- `@pnpm/config`

close #2294
PR #2312
@zkochan
Copy link
Member

zkochan commented Feb 2, 2020

🚢 4.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zkochan zkochan

Labels
area: monorepo Everything related to the pnpm workspace feature type: bug
Projects
None yet
Milestone
v4.9
Development

Successfully merging a pull request may close this issue.

fix: add --save-dev -r pnpm/pnpm
2 participants
@zkochan @amctavish