Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid recursive command throws "...is not a function" error instead of showing help message #2397

Closed
mcmillenb opened this issue Mar 5, 2020 · 0 comments · Fixed by #2407
Closed

Invalid recursive command throws "...is not a function" error instead of showing help message #2397

mcmillenb opened this issue Mar 5, 2020 · 0 comments · Fixed by #2407
Assignees
@zkochan
Labels
area: cli state: in progress type: bug
Milestone
v4.11

Comments

@mcmillenb
Copy link

pnpm version:

4.11.1

Code to reproduce the issue:

mkdir pnpm-test && cd pnpm-test
pnpm init -y
pnpm recursive build

Expected behavior:

A help message saying "unknown command" similar to running pnpm build or another invalid command.

Actual behavior:

Error message:

ERROR  cmd_1.default[(cmd || "help")] is not a function
at _onTimeout     ../../../../usr/local/lib/node_modules/pnpm/lib/main.js:152  const result = cmd_1.def…
at listOnTimeout  internal/timers.js:531

pnpm-debug.log:
https://gist.github.com/mcmillenb/d52c115a5e55e0611e6cf5f4147aebb1

Additional information:

  • node -v prints: v12.10.0
  • Windows, OS X, or Linux?: OS X
@zkochan zkochan self-assigned this Mar 8, 2020
zkochan added a commit that referenced this issue Mar 8, 2020
@zkochan
fix(CLI): correct error on unknown recursive cmds
b02b5c6 
close #2397
@zkochan zkochan mentioned this issue Mar 8, 2020
Merged
@zkochan zkochan added this to the v4.11 milestone Mar 8, 2020
zkochan added a commit that referenced this issue Mar 8, 2020
@zkochan
fix(CLI): correct error on unknown recursive cmds
1ea37ad 
close #2397
PR #2407

BREAKING CHANGE: @pnpm/parse-cli-args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zkochan zkochan

Labels
area: cli state: in progress type: bug
Projects
None yet
Milestone
v4.11
Development

Successfully merging a pull request may close this issue.

fix(CLI): correct error on unknown recursive cmds pnpm/pnpm
2 participants
@zkochan @mcmillenb