Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace peer dependencies not subtitude to real version when published #2467

Closed
thynson opened this issue Apr 7, 2020 · 2 comments · Fixed by #2727
Closed

Workspace peer dependencies not subtitude to real version when published #2467

thynson opened this issue Apr 7, 2020 · 2 comments · Fixed by #2727
Milestone

Comments

@thynson
Copy link
Sponsor Contributor

thynson commented Apr 7, 2020

pnpm version: 4.12.1

Code to reproduce the issue:

Suppose a monorepo with package foo and bar and foo is a peer dependency of bar which specified by workspace:*. When publishing them to registry, npm will alert you with message like bar@*.*.* requires a peer of foo@workspace:* but version *.*.* is installed

Expected behavior:

No alert abount unmet peer dependencies when install them from registry.

@zkochan
Copy link
Member

zkochan commented Apr 8, 2020

@thynson do you mean that the workspace range is used in peer dependencies? Like bar has this in the package.json:

"peerDependencies": {
  "foo": "workspace:*"
}

@thynson
Copy link
Sponsor Contributor Author

thynson commented Apr 9, 2020

Exactly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants