Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pnpm doesn't honor the npm setting script-shell while it should #2942

Closed
b4git opened this issue Oct 20, 2020 · 1 comment · Fixed by #2943
Closed

pnpm doesn't honor the npm setting script-shell while it should #2942

b4git opened this issue Oct 20, 2020 · 1 comment · Fixed by #2943
Assignees
Milestone

Comments

@b4git
Copy link

b4git commented Oct 20, 2020

pnpm version: 5.9.x

Code to reproduce the issue:

// just create a package.json in an empty directory with following content:
{
  "scripts": {
    "test": "echo $SHELL; shopt;"
  }
}

// Then, run the following commands: 
//  0. In Windows run command:  npm config set script-shell "C:\\Program Files\\Git\\bin\\bash.exe"
//   0. Or in Linux run:    npm config set script-shell "/usr/bin/bash"
//   1. npm test
//    2. pnpm test

Expected behavior: The results of npm test and pnpm test should be equivalent.

Actual behavior: Results are distinct

Additional information:

  • node -v prints: v14.x
  • Windows, OS X, or Linux?: All
@b4git
Copy link
Author

b4git commented Oct 20, 2020

Related Post: #2931

@zkochan zkochan added this to the v5.10 milestone Oct 20, 2020
@zkochan zkochan self-assigned this Oct 20, 2020
zkochan added a commit that referenced this issue Oct 20, 2020
zkochan added a commit that referenced this issue Oct 20, 2020
zkochan added a commit that referenced this issue Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants