Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completions do not install #3221

Closed
esdmr opened this issue Mar 5, 2021 · 2 comments
Closed

Completions do not install #3221

esdmr opened this issue Mar 5, 2021 · 2 comments
Milestone

Comments

@esdmr
Copy link

esdmr commented Mar 5, 2021

pnpm version: 5.18.1

Code to reproduce the issue:

pnpm install-completion
# Select any shell

Expected behavior:

After selecting shell, it should correctly print prompts and wait for user input.

Actual behavior:

All user inputs happen at once and completions are not installed.

✔ Which Shell do you use ? · fish
Very well, we will install using undefined
? Which path then ? Must be absolute. ‣ ? We will install completion to ~/.config/fish/config.fish, is it ok ? (y/$HOME/.local/share/npm/lib/node_modules/pnpm/dist/pnpm.js:8450
      throw new Error("options.location is required");
            ^

Error: options.location is required
    at Object.install ($HOME/.local/share/npm/lib/node_modules/pnpm/dist/pnpm.js:8450:13)
    at install ($HOME/.local/share/npm/lib/node_modules/pnpm/dist/pnpm.js:8557:21)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at async $HOME/.local/share/npm/lib/node_modules/pnpm/dist/pnpm.js:123194:7

Additional information:

  • node -v prints: v15.10.0
  • Windows, macOS, or Linux?: Linux (Ubuntu 20.04.02)
  • Shell: Fish
  • NPM Prefix: $HOME/.local/share/npm
@esdmr
Copy link
Author

esdmr commented Mar 5, 2021

I've filed a PR fixing this at pnpm/tabtab#6

@zkochan zkochan added this to the v5.18 milestone Mar 5, 2021
@zkochan zkochan closed this as completed in 1676a42 Mar 5, 2021
zkochan added a commit that referenced this issue Mar 5, 2021
@zkochan
Copy link
Member

zkochan commented Mar 8, 2021

🚢 5.18.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants