-
-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positive report for peer dependency warning with experimental value #3753
Labels
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@mhatvan this is the first time I see such semver spec Does it work with npm/Yarn? |
I am not working on that client project anymore. Probably super edge case semver definition, ticket can be closed imo. |
I just checked, neither npm nor Yarn v1 print a warning in such case, so we should fix this. |
zkochan
added a commit
that referenced
this issue
Nov 14, 2021
zkochan
added a commit
that referenced
this issue
Nov 14, 2021
zkochan
added a commit
that referenced
this issue
Nov 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
pnpm version: v6.14.7
Code to reproduce the issue:
Install
reactfire@3.0.0-rc.0
andreact@17.0.1
asdependencies
.Expected behavior:
No peer dependency warning since
react@>=16
should be satisfied byreact@17.0.1
Actual behavior:
ERROR packages/common: reactfire@3.0.0-rc.0 requires a peer of react@>=16 || experimental but version 17.0.1 was installed.
Additional information:
node -v
prints: v14.17.1The text was updated successfully, but these errors were encountered: