Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive report for peer dependency warning with experimental value #3753

Closed
mcmxcdev opened this issue Sep 7, 2021 · 5 comments · Fixed by #3986
Closed

False positive report for peer dependency warning with experimental value #3753

mcmxcdev opened this issue Sep 7, 2021 · 5 comments · Fixed by #3986
Assignees

Comments

@mcmxcdev
Copy link
Contributor

mcmxcdev commented Sep 7, 2021

pnpm version: v6.14.7

Code to reproduce the issue:

Install reactfire@3.0.0-rc.0 and react@17.0.1 as dependencies.

Expected behavior:

No peer dependency warning since react@>=16 should be satisfied by react@17.0.1

Actual behavior:

ERROR  packages/common: reactfire@3.0.0-rc.0 requires a peer of react@>=16 || experimental but version 17.0.1 was installed.

Additional information:

  • node -v prints: v14.17.1
  • Windows, macOS, or Linux?: Ubuntu 21.04
@lucas-labs

This comment has been minimized.

@zkochan

This comment has been minimized.

@zkochan
Copy link
Member

zkochan commented Oct 13, 2021

@mhatvan this is the first time I see such semver spec >=16 || experimental

Does it work with npm/Yarn?

@mcmxcdev
Copy link
Contributor Author

I am not working on that client project anymore.

Probably super edge case semver definition, ticket can be closed imo.

@zkochan
Copy link
Member

zkochan commented Oct 14, 2021

I just checked, neither npm nor Yarn v1 print a warning in such case, so we should fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants