You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a developer, I want to disable execution of package scripts, but cannot as no CLI flag nor config file option exists that applies to pnpm fetch.
Describe the solution you'd like
A lot of what happens in pnpm fetch also occurs in pnpm install, which makes sense given its purpose (splitting up download and install steps to enable better caching in differential systems like Docker or (in my case) the Please build system.
Holistically it would make sense that any pnpm install flags applicable to pnpm fetch be copied over. For the scope of this request however, bringing over --ignore-scripts would suffice.
Describe the drawbacks of your solution
pnpm fetch is experimental, so my request here my be standing at odds with the intended design. For all I know, its entirely possible that the command was not supposed to trigger package scripts (though the side effects cache being on by default in v7 implies this would not be the case).
Beyond that, the only drawback I see is a small increase to the source focused on a specific command. Something which wouldn't really apply for an alternative solution such as using a config file.
Stability shouldn't be impacted by this.
Describe alternatives you've considered
For my use case there are 3 options.
Allow package scripts to run (failing currently as I haven't made NodeJS an input to the build step, but an easy change)
Instead use pnpm install (much less granularity in build steps meaning more cache misses, need to redo integration)
Create a much deeper API-level integration with Please (huge amount of effort, not justifiable for the current POC, may be done later on subject to justification e.g. project size, reuse in other projects).
The text was updated successfully, but these errors were encountered:
Silic0nS0ldier
changed the title
Support --ignore-scripts in pnpm fetch command
Support running pnpm fetch without triggering package scripts
Mar 20, 2022
Describe the user story
As a developer, I want to disable execution of package scripts, but cannot as no CLI flag nor config file option exists that applies to
pnpm fetch
.Describe the solution you'd like
A lot of what happens in
pnpm fetch
also occurs inpnpm install
, which makes sense given its purpose (splitting up download and install steps to enable better caching in differential systems like Docker or (in my case) the Please build system.Holistically it would make sense that any
pnpm install
flags applicable topnpm fetch
be copied over. For the scope of this request however, bringing over--ignore-scripts
would suffice.Describe the drawbacks of your solution
pnpm fetch
is experimental, so my request here my be standing at odds with the intended design. For all I know, its entirely possible that the command was not supposed to trigger package scripts (though the side effects cache being on by default in v7 implies this would not be the case).Beyond that, the only drawback I see is a small increase to the source focused on a specific command. Something which wouldn't really apply for an alternative solution such as using a config file.
Stability shouldn't be impacted by this.
Describe alternatives you've considered
For my use case there are 3 options.
pnpm install
(much less granularity in build steps meaning more cache misses, need to redo integration)The text was updated successfully, but these errors were encountered: