Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub-dependencies cannot be found after updating pnpm from 7.29.1 to 7.29.2 #6213

Closed
Leksat opened this issue Mar 14, 2023 · 10 comments · Fixed by #6138
Closed

Sub-dependencies cannot be found after updating pnpm from 7.29.1 to 7.29.2 #6213

Leksat opened this issue Mar 14, 2023 · 10 comments · Fixed by #6138
Assignees
Milestone

Comments

@Leksat
Copy link

Leksat commented Mar 14, 2023

pnpm version:

7.29.2

Code to reproduce the issue:

https://github.com/Leksat/pnpm-7.29.2-issue

Expected behavior:

The build script works. See https://github.com/Leksat/pnpm-7.29.2-issue/actions/runs/4413954837/jobs/7735055980 (with pnpm@7.29.1)

Actual behavior:

The build script fails because sub-dependencies (e.g. babel-preset-env) cannot be found. See https://github.com/Leksat/pnpm-7.29.2-issue/actions/runs/4413954837/jobs/7735056231 (with pnpm@7.29.2)

Additional information:

  • node -v prints: v18.14.0
  • Windows, macOS, or Linux?: macOS (locally) and Linux (GitHub CI)
@Leksat Leksat changed the title Sub-dependencies cannot be found after updating pnpm v7.29.2 Sub-dependencies cannot be found after updating pnpm from 7.29.1 to 7.29.2 Mar 14, 2023
@fireairforce
Copy link
Member

the same issue for vitest: vitest-dev/vitest#3009

@rex-ll
Copy link

rex-ll commented Mar 14, 2023

the same problem

@MartinX3
Copy link

MartinX3 commented Mar 14, 2023

Thank you for the report, now I know that I didn't fucked up my own project and save time. :D

I assume it happens because of #6197

MartinX3 added a commit to Rad-Touristik-Club-Koln-e-V-1972/Rad-Touristik-Club-Koln-e-V-1972.github.io that referenced this issue Mar 14, 2023
@await-ovo
Copy link
Member

did this related to extend-node-path? I set extend-node-path=true on the repo you provided,looks like build works fine.

@Leksat
Copy link
Author

Leksat commented Mar 14, 2023

@await-ovo shouldn't it be true by default? https://pnpm.io/npmrc#extend-node-path

@Leksat
Copy link
Author

Leksat commented Mar 14, 2023

But I can confirm that extend-node-path=true seems to solve the issue. I added it to the repo: https://github.com/Leksat/pnpm-7.29.2-issue/actions/runs/4415215332

@zkochan
Copy link
Member

zkochan commented Mar 14, 2023

I have downgraded latest to v7.29.1 for now.

@zkochan
Copy link
Member

zkochan commented Mar 15, 2023

🚢 7.29.3

@zkochan zkochan added this to the v7.29 milestone Mar 15, 2023
@Leksat
Copy link
Author

Leksat commented Mar 15, 2023

It works 🎉 https://github.com/Leksat/pnpm-7.29.2-issue/actions/runs/4425468120

Thank you for the quick fix!

@Hurtak
Copy link

Hurtak commented Mar 15, 2023

I can also confirm that .3 fixes the issue
image

https://github.com/Hurtak/vitest-bug-repro/actions/runs/4426277097/jobs/7762372120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants