Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different behavior with npm install #67

Closed
PeterDaveHello opened this issue Feb 1, 2016 · 1 comment
Closed

Different behavior with npm install #67

PeterDaveHello opened this issue Feb 1, 2016 · 1 comment
Assignees
@zkochan
Labels
size: S

Comments

@PeterDaveHello
Copy link
Contributor

If I run npm install in dir node_modules, npm will not create a new node_modules, it'll just put the installed lib under the same node_modules. but pnpm will create a new node_modules, I'm not sure if this is expected.
@rstacruz
Copy link
Member

rstacruz commented Feb 2, 2016

yeah, this is bit of a deviation that should probably be corrected. at the moment, it looks for the existence of package.json, not node_modules (that i later found out to be the case).

In the mean time, you can work around this behavior by adding a package.json to your project.

@zkochan zkochan added this to Priority in Status Feb 23, 2017
@zkochan zkochan self-assigned this Apr 21, 2017
zkochan added a commit that referenced this issue Apr 22, 2017
@zkochan
refactor: avoid using read-pkg-up
60412d9 
BREAKING CHANGE:

API should be called in the folder that has a package.json file.
pnpm won't search up for a package.json file.

Close #67
@zkochan zkochan removed this from Priority in Status Jan 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zkochan zkochan

Labels
size: S
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rstacruz @zkochan @PeterDaveHello