Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-options in .npmrc doesn't get applied #7596

Closed
2 of 4 tasks
mhamri opened this issue Jan 30, 2024 · 3 comments · Fixed by #7601
Closed
2 of 4 tasks

node-options in .npmrc doesn't get applied #7596

mhamri opened this issue Jan 30, 2024 · 3 comments · Fixed by #7601
Assignees

Comments

@mhamri
Copy link

mhamri commented Jan 30, 2024

Verify latest release

  • I verified that the issue exists in the latest pnpm release

pnpm version

8.15.1

Which area(s) of pnpm are affected? (leave empty if unsure)

CLI, Package manager compatibility

Link to the code that reproduces this issue or a replay of the bug

No response

Reproduction steps

create this script in package.json

{
  "name": "heap-test",
  "scripts": {
    "heap": "node -e \"console.log(require('v8').getHeapStatistics().heap_size_limit /(1024*1024) )\"",
   }
}

create this .npmrc

node-linker=hoisted
node-options="--max-old-space-size=4096"

then run npm run heap and pnpm run heap

image

Describe the Bug

we can set node options in the .npmrc, unfortunately pnpm doesn't recognize that

Expected Behavior

same behavior as npm and it set node-options

Which Node.js version are you using?

v16.20.2

Which operating systems have you used?

  • macOS
  • Windows
  • Linux

If your OS is a Linux based, which one it is? (Include the version if relevant)

No response

@nachoaldamav
Copy link
Contributor

nachoaldamav commented Jan 30, 2024

I think this should be a feature, not a bug, as in pnpm.io we don't have that option.

@mhamri
Copy link
Author

mhamri commented Jan 30, 2024

I'm not putting my nose into how you want to manage your task board, but to me not supporting .npmrc basic functionality is a neglected/missing feature hence I chose bug.

@mhamri
Copy link
Author

mhamri commented Feb 1, 2024

You are a speed demon ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants