Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove global bin when unlink #2425

Merged
merged 13 commits into from
Jun 20, 2020
Merged

fix: remove global bin when unlink #2425

merged 13 commits into from
Jun 20, 2020

Conversation

yaodingyd
Copy link
Member

@yaodingyd yaodingyd commented Mar 16, 2020 •
edited
Loading

Close #1584

@yaodingyd yaodingyd requested a review from zkochan as a code owner March 16, 2020 03:04
@yaodingyd yaodingyd changed the title fix: remove global bin when unlink (WIP) fix: remove global bin when unlink Mar 16, 2020
@yaodingyd yaodingyd changed the title (WIP) fix: remove global bin when unlink fix: remove global bin when unlink Jun 19, 2020
zkochan
zkochan reviewed Jun 19, 2020
View reviewed changes
Copy link
Member

@zkochan zkochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe the changes you have made in the packages by running pnpx changeset. (You can create a few if needed)

And a new test is needed

packages/remove-bins/src/removeBins.ts Outdated Show resolved Hide resolved
packages/remove-bins/src/removeBins.ts Show resolved Hide resolved
yaodingyd and others added 4 commits June 19, 2020 21:56
@yaodingyd @zkochan
Update packages/remove-bins/package.json
7cb461e 
Co-authored-by: Zoltan Kochan <zkochan@users.noreply.github.com>
@yaodingyd
add changeset
781e087
@yaodingyd
update readme
43a7f15
@yaodingyd
add test
ede2ed0
@zkochan zkochan added this to the v5.2 milestone Jun 20, 2020
@zkochan zkochan merged commit 57d08f3 into master Jun 20, 2020
@zkochan zkochan deleted the unlink-bin branch June 20, 2020 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkochan zkochan zkochan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5.2
Development

Successfully merging this pull request may close these issues.

"pnpm unlink" does not remove global bin
2 participants
@yaodingyd @zkochan