Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: --loglevel #2465

Merged
merged 8 commits into from Apr 6, 2020
Merged

feat: --loglevel #2465

merged 8 commits into from Apr 6, 2020

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Apr 5, 2020

close #2140

@zkochan zkochan added this to the v4.13 milestone Apr 5, 2020
@zkochan zkochan requested a review from a team April 5, 2020 17:16
aparajita
aparajita requested changes Apr 5, 2020
View reviewed changes
packages/common-cli-options-help/src/index.ts Outdated Show resolved Hide resolved
packages/default-reporter/src/reporterForClient/reportMisc.ts Outdated Show resolved Hide resolved
packages/default-reporter/src/index.ts Outdated Show resolved Hide resolved
aparajita
aparajita requested changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@aparajita aparajita left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for listening! 😁I hope to contribute some actual code soon.

OMG I just noticed ви українець! Ukraine is my favorite country! I have many, many friends there. I've been there four or five times. My grandparents came from Ukraine.

packages/common-cli-options-help/src/index.ts Outdated Show resolved Hide resolved
@zkochan
Copy link
Member Author

zkochan commented Apr 6, 2020

Nice. What part of Ukraine are your grandparents from? I was also in San Francisco a few times, so not far from you.

@zkochan zkochan merged commit f425651 into master Apr 6, 2020
@zkochan zkochan deleted the feat/loglevel branch April 6, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aparajita aparajita aparajita requested changes

Assignees
No one assigned
Labels
area: reporting type: feature
Projects
None yet
Milestone
v4.13
Development

Successfully merging this pull request may close these issues.

--loglevel
2 participants
@zkochan @aparajita