New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: public-hoist-pattern #2631
Conversation
2f85911
to
66c5ae6
Compare
66c5ae6
to
5ade50e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question: can the hoist pattern be specified by a setting in a per-package .npmrc?
No, currently hoisting is not possible per package. It can be set once for a monorepo or once for a project with a single package.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once for a monorepo or once for a project with a single package.json is sufficient. So the user would set public-host-pattern=<pattern>
in the project .npmrc?
Yes. But I think we will be updating the default value of that setting when we will find issues in the ecosystem. This way new users will not get disappointed by pnpm. I think @vjpr might have a list already |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, just want to be sure all this is well documented.
sorry for all the notifications. Hopefully, now it will pass. |
This is a really interesting solution. But usually the fixes for such packages are to add the missing |
I think there are some buggy pluggable frameworks like angular and karma that might benefit from this feature. Like angular now only works with shamefully-flatten. Maybe we can come up with a pattern that is not |
Is there a GH issue open for Angular support? |
See my proposal in #2634 for an elegant way to deal with individual packages that would be too difficult for a pattern to deal with. |
close #2628