Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: don't request the full metadata #2633

Merged
merged 3 commits into from Jun 15, 2020
Merged

perf: don't request the full metadata #2633

merged 3 commits into from Jun 15, 2020

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Jun 15, 2020

ref #2632

@zkochan zkochan requested a review from aparajita June 15, 2020 19:07
@zkochan zkochan changed the title perf(outdated): don't request the full metadata perf: don't request the full metadata Jun 15, 2020
Copy link
Contributor

@aparajita aparajita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that was simple! What kind of speed improvement are you seeing?

@zkochan
Copy link
Member Author

zkochan commented Jun 15, 2020

before

Executed in    5.93 secs   fish           external
   usr time    4.13 secs  494.00 micros    4.13 secs
   sys time    0.91 secs  141.00 micros    0.91 secs

after

Executed in    5.13 secs   fish           external
   usr time    2.34 secs  479.00 micros    2.34 secs
   sys time    0.56 secs  137.00 micros    0.56 secs

@zkochan zkochan merged commit 6808c43 into master Jun 15, 2020
@zkochan zkochan deleted the outdated-2632 branch June 15, 2020 20:00
@zkochan zkochan added this to the v5.2 milestone Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants