feat: pnpm.overrides #2946
Merged
feat: pnpm.overrides #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zkochan this can be used only on root right? in case of yes, does also display warnings if is being defined inside the workspace like yarn does? |
juanpicado
reviewed
Oct 21, 2020
| test('versions are replaced with versions specified through "resolutions" field (for Yarn compatibility)', async (t: tape.Test) => { | ||
| const project = prepareEmpty(t) | ||
|
|
||
| await addDistTag({ package: 'bar', version: '100.0.0', distTag: 'latest' }) |
There was a problem hiding this comment.
Both scenarios are almost identical (aside from the input to addDependenciesToPackage), maybe you'd like to mix them, but that's just based on my own taste.
There was a problem hiding this comment.
I don't mind code duplication in tests.
|
Yes, it only works on the root. No, there are no warnings at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pnpm's implementation of "resolutions" #1221 does not match Yarn's implementation, so to avoid confusion, I am renaming it to overrides. npm is also planning to have an overrides field but I don't think we'll use the same specs, so our option will be under a pnpm section of the package.json file.