Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: escape a colon in tarball dependency ID #3183

Merged
merged 1 commit into from
Feb 22, 2021
Merged

fix: escape a colon in tarball dependency ID #3183

merged 1 commit into from
Feb 22, 2021

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Feb 22, 2021

close #3182

@zkochan zkochan added this to the v5.18 milestone Feb 22, 2021
@zkochan zkochan requested a review from a team February 22, 2021 01:00
Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zkochan zkochan merged commit a00ee00 into main Feb 22, 2021
@zkochan zkochan deleted the fix/3182 branch February 22, 2021 09:21
zkochan added a commit that referenced this pull request Feb 22, 2021
Copy link
Contributor

@statianzo statianzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Looks good.

@Torvin
Copy link

Torvin commented Feb 23, 2021

Thank you so much for fixing it so quickly. How soon would the new version be published?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install fails if package url contains port number
4 participants