feat: workspace:^ and workspace:~ aliases (#3116) #3368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -351,12 +351,16 @@ test('convert specs with workspace protocols to regular version ranges', async ( | |||
| 'is-positive': '1.0.0', | |||
| 'lodash.delay': '~4.1.0', | |||
| odd: 'workspace:is-odd@*', | |||
| rd: 'workspace:ramda@^', | |||
There was a problem hiding this comment.
I'm having problem with this dependency, the test passes if I remove rd: 'workspace:ramda@^' and ramda references. The error message says that is-negative could not be found.
Cannot resolve workspace protocol of dependency "is-negative" because this dependency is not installed
Do you know how could I troubleshoot this error?
There was a problem hiding this comment.
I think it's fixed now. Among the things that I modified to make it work, I had to change the versions of test packages to match those specified in verdaccio/node_modules/storage-cache.
Is this ok? Or am I just fooling myself?
javier-garcia-meteologica
force-pushed
the
workspace_aliases
branch
from
fe78626
to
598ceb3
Compare
zkochan
requested changes
Apr 20, 2021
zkochan
reviewed
Apr 21, 2021
zkochan
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to support for workspace:^ and workspace:~ aliases.