fix: --lockfile-only in CI and with frozen-lockfile=true #4955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghiscoding
reviewed
Jun 30, 2022
| @@ -269,7 +269,7 @@ export async function mutateModules ( | |||
| !opts.fixLockfile && | |||
| installsOnly && | |||
| ( | |||
| frozenLockfile || | |||
| frozenLockfile && !opts.lockfileOnly || | |||
There was a problem hiding this comment.
is that expected to be written without brackets () around it? I didn't test anything, I'm just asking. I mean should it be (frozenLockfile && !opts.lockfileOnly)? If not then Prettier is probably to blame here, it's confusing when it's on 1 line
There was a problem hiding this comment.
It will work without brackets just fine. && has bigger priority than ||
There was a problem hiding this comment.
ahh ok I forgot about that, cool 👍🏻
kenrick95
approved these changes
Jun 30, 2022
This was referenced Jun 30, 2022
This was referenced Aug 8, 2022
This was referenced Aug 16, 2022
This was referenced Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4951