Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add experimental use-inline-specifiers-lockfile-format #5091

Merged
merged 3 commits into from
Jul 27, 2022

Commits on Jul 26, 2022

  1. Configuration menu
    Copy the full SHA
    7e2b76a View commit details
    Browse the repository at this point in the history
  2. fix(lockfile-file): check importers key for shared lockfile format

    The `convertFromLockfileFileMutable` function reverts changes from
    `normalizeLockfile` when not using the shared lockfile format.
    
      - The non-shared lockfile format puts fields like `specifiers`,
        `dependencies`, `devDependencies`, `optionalDependencies`, and
        `dependenciesMeta` on the root of the lockfile. This is typically
        the case for a repo not using pnpm workspaces.
      - The shared lockfile format puts these under a `importers` block
        scoped by a path.
    
    The `use-inline-specifiers-lockfile-format` feature flag removes the
    `specifiers` block in favor of putting each specifier next to the
    resolved version within each `dependencies`, `devDependencies`, etc
    block.
    
    This means the `convertFromLockfileFileMutable` function can no longer
    check for `specifiers` to detect the whether the "shared" format is
    used. @zkochan suggested checking for `importers` instead, which should
    have the same effect.
    pnpm#5091 (comment)
    gluxon committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    cdfd506 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3cd2784 View commit details
    Browse the repository at this point in the history