Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read the workspace project location globs from package.json #5554

Closed
wants to merge 1 commit into from

Conversation

zkochan
Copy link
Member

@zkochan zkochan commented Oct 25, 2022

Related discussion: #3205

@zkochan zkochan requested a review from a team October 25, 2022 23:50
@shellscape
Copy link
Contributor

shellscape commented Oct 26, 2022

Generally not in favor of this citing my comment #3205 (comment). There are two camps here: those who want package.json to contain every bit of config for the workspace and willing to pollute the hell out of the file, and those who prefer many files with distinct intent. I'm strongly in favor of separation of concerns and putting as little in package.json as possible. Perhaps if package.yaml was a thing I wouldn't feel so strongly, but JSON is not a good configuration language, and package.json was never meant to contain anything but metadata for NPM packages.

This is a great example of "just because yarn did something, doesn't mean we should."

@zkochan
Copy link
Member Author

zkochan commented Oct 26, 2022

Closing for now. Maybe the warning that I added via #5547 will be enough.

@zkochan zkochan closed this Oct 26, 2022
@liujiayii
Copy link

But now it is the standard of npm, It's not just yarn
.

@shellscape
Copy link
Contributor

I don't think that's a convincing argument. this project was created to counter the deficiencies in NPM. they've historically made very poor decisions, and using them as a source of truth has never really been wise

@juanpicado
Copy link
Member

I could not more agree with @shellscape , already we can see the side effects of polluted package.json, even with almost no using many external metadata at the package.json some practices are leading to this, I've seen many projects doing this more often if we the package manager encourage this at the end users might pay the price eventually npm/feedback#765 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants